voonhous commented on PR #12539: URL: https://github.com/apache/hudi/pull/12539#issuecomment-2638778158
As discussed with @danny0405 , this is not required. `issuedOffset` is already a modification/completion time, as can be seen in the line changes below in [HUDI-6157](https://github.com/apache/hudi/pull/8611) 1. https://github.com/apache/hudi/pull/8611/files#diff-1ef2e614309c45d4eaec0bd7e5e3b51e8f853fd7946ec6ab63f52b707de1b522R288 2. https://github.com/apache/hudi/pull/8611/files#diff-1ef2e614309c45d4eaec0bd7e5e3b51e8f853fd7946ec6ab63f52b707de1b522R638 3. https://github.com/apache/hudi/pull/8611/files#diff-1ef2e614309c45d4eaec0bd7e5e3b51e8f853fd7946ec6ab63f52b707de1b522R655-R662 Also, the work here was done due to a misunderstanding on my part that it is a state-compatibility issue. Hence, the code changes made in this PR are done to address that and are hence, also invalid. Closing this PR as it is no longer valid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
