lokeshj1703 commented on code in PR #12111: URL: https://github.com/apache/hudi/pull/12111#discussion_r1944203784
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaSourceUtil.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.sources.helpers; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.util.StringUtils; +import org.apache.hudi.common.util.hash.HashID; +import org.apache.hudi.utilities.exception.HoodieReadFromSourceException; +import org.apache.hudi.utilities.schema.SchemaProvider; + +import com.google.crypto.tink.subtle.Base64; + +import java.util.Objects; + +import static org.apache.hudi.utilities.config.KafkaSourceConfig.KAFKA_VALUE_DESERIALIZER_SCHEMA; + +public class KafkaSourceUtil { + + public static final String NATIVE_KAFKA_CONSUMER_GROUP_ID = "group.id"; + public static final int GROUP_ID_MAX_BYTES_LENGTH = 255; + + public static void configureSchemaDeserializer(SchemaProvider schemaProvider, TypedProperties props) { + if (schemaProvider == null || Objects.isNull(schemaProvider.getSourceSchema())) { + throw new HoodieReadFromSourceException("SchemaProvider has to be set to use KafkaAvroSchemaDeserializer"); + } + props.put(KAFKA_VALUE_DESERIALIZER_SCHEMA.key(), schemaProvider.getSourceSchema().toString()); + // assign consumer group id based on the schema, since if there's a change in the schema we ensure KafkaRDDIterator doesn't use cached Kafka Consumer + String groupId = props.getString(NATIVE_KAFKA_CONSUMER_GROUP_ID, ""); Review Comment: @danny0405 @vamsikarnika Is there a consensus here on how to proceed further with the PR? It seems like group id is used in the cache key so updating it would help with renewing the KafkaConsumer. (Ref: org.apache.spark.streaming.kafka010.KafkaRDDIterator). Please correct me if I am wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
