nsivabalan opened a new pull request, #12797:
URL: https://github.com/apache/hudi/pull/12797

   ### Change Logs
   
   Fixing metadata metrics to honor metrics prefix. 
   Fix: Will honor the metrics prefix with "_metadata" suffixed. 
   
   For eg, incase of "clean_duration" metric:
   with metrics prefix set to "ohds":
   data table metric name => "ohds_clean_duration" 
   and metadata metric name => "ohds_metadata_clean_duration" 
   
   ### Impact
   
   One set of metrics for metadata table. 
   
   I could not write an automated tests. But manually verified by using console 
metrics. 
   ```
   ohds.timer.deltastreamer
   ohds_metadata.timer.deltacommit
   ```
   
   Prior to the fix, each metric for metadata will have the table name prefixed 
w/ metric name. For datatable, still the metircsPrefix was honored. 
   ```
   ohds.timer.deltastreamer
   hoodie_trips_metadata.timer.deltacommit
   ```
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the 
risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, 
config, or user-facing change. If not, put "none"._
   
   - _The config description must be updated if new configs are added or the 
default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. 
Please create a Jira ticket, attach the
     ticket number here and follow the 
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to 
make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to