danny0405 commented on code in PR #12803:
URL: https://github.com/apache/hudi/pull/12803#discussion_r1948357175
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -211,6 +212,29 @@ public class HoodieWriteConfig extends HoodieConfig {
.withDocumentation("Key generator class, that implements
`org.apache.hudi.keygen.KeyGenerator` "
+ "extract a key out of incoming records.");
+ public static final ConfigProperty<String> RECORD_SIZE_ESTIMATOR_CLASS_NAME
= ConfigProperty
+ .key("hoodie.record.size.estimator.class")
+ .defaultValue(AverageRecordSizeEstimator.class.getName())
+ .markAdvanced()
+ .sinceVersion("1.0.0")
+ .withDocumentation("Class that estimates the size of records written by
implementing "
+ + "`org.apache.hudi.estimator.RecordSizeEstimator`. Default
implementation is `org.apache.hudi.estimator.AverageRecordSizeEstimator`");
+
+ public static final ConfigProperty<Integer>
RECORD_SIZE_ESTIMATOR_MAX_COMMITS = ConfigProperty
+ .key("hoodie.record.size.estimator.max.commits")
Review Comment:
Can we eliminate these options as much as possibe, I don't think the
community users have a chance to config these things, hoodie has too many
options now, we should keep restraint about introducing new options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
