the-other-tim-brown commented on code in PR #12164:
URL: https://github.com/apache/hudi/pull/12164#discussion_r1949879894
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -968,18 +960,15 @@ private void startCommitWithTime(String instantTime,
String actionType, HoodieTa
executeUsingTxnManager(Option.empty(), () -> tryUpgrade(metaClient,
Option.empty()));
}
CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
- HoodieTimeline.COMMIT_ACTION, () ->
tableServiceClient.rollbackFailedWrites());
- startCommit(instantTime, actionType, metaClient);
- }
+ HoodieTimeline.COMMIT_ACTION, () ->
tableServiceClient.rollbackFailedWrites(metaClient));
- private void startCommit(String instantTime, String actionType,
HoodieTableMetaClient metaClient) {
LOG.info("Generate a new instant time: {} action: {}", instantTime,
actionType);
// check there are no inflight restore before starting a new commit.
HoodieTimeline inflightRestoreTimeline =
metaClient.getActiveTimeline().getRestoreTimeline().filterInflightsAndRequested();
ValidationUtils.checkArgument(inflightRestoreTimeline.countInstants() == 0,
- "Found pending restore in active timeline. Please complete the restore
fully before proceeding. As of now, "
- + "table could be in an inconsistent state. Pending restores: " +
Arrays.toString(inflightRestoreTimeline.getInstantsAsStream()
-
.map(HoodieInstant::requestedTime).collect(Collectors.toList()).toArray()));
+ () -> "Found pending restore in active timeline. Please complete the
restore fully before proceeding. As of now, "
Review Comment:
This avoids creating the string if it is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
