vinishjail97 commented on code in PR #12664:
URL: https://github.com/apache/hudi/pull/12664#discussion_r1950012310
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java:
##########
@@ -213,4 +216,8 @@ private Long parsedToSeconds(String time) {
return TimelineUtils.parseDateFromInstantTimeSafely(time).orElseThrow(()
-> new HoodieCompactionException("Failed to parse timestamp " + time))
.getTime() / 1000;
}
+
+ private BaseHoodieCompactionPlanGenerator
createCompactionPlanGenerator(String planGeneratorClass, HoodieTable table,
HoodieEngineContext context, HoodieWriteConfig config) {
Review Comment:
CompactionStrategy takes in the list of compaction operations and decides
which ones to pick it up based on strategy logic. This is for the ability to
keep track of metadata from previous compaction results in extraMetadata and
then decide the plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
