nsivabalan commented on code in PR #12110:
URL: https://github.com/apache/hudi/pull/12110#discussion_r1951664691
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1396,7 +1397,8 @@ public static HoodieTableFileSystemView
getFileSystemView(HoodieTableMetaClient
metaClient.createNewInstantTime(false));
timeline = factory.createDefaultTimeline(Stream.of(instant),
metaClient.getActiveTimeline()::getInstantDetails);
}
- return new HoodieTableFileSystemView(metaClient, timeline);
+ HoodieEngineContext engineContext = new
HoodieLocalEngineContext(metaClient.getStorageConf());
Review Comment:
yeah. I did notice that. but while reviewing it was bit confusing at times,
whether it could refer to DT FSV. would be good to name it explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
