[ 
https://issues.apache.org/jira/browse/HUDI-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927041#comment-17927041
 ] 

Geser Dugarov edited comment on HUDI-7222 at 2/14/25 3:59 PM:
--------------------------------------------------------------

[~linliu] hi!
I've proposed import check for grouping and ordering here: 
https://github.com/apache/hudi/pull/12837.
But unused import check is a harder task. In my PR I did it manually.

The problem with this check is that a lot of Scala classes are affected, and it 
would cause a lot of conflicts in PRs during some transition period until all 
developers will rebase on the latest version with Scala style checking.


was (Author: JIRAUSER301110):
[~linliu] hi!
I've proposed import check for grouping and ordering here: 
https://github.com/apache/hudi/pull/12837.
But unused import check is a harder task.

The problem with this check is that a lot of Scala classes are affected, and it 
would cause a lot of conflicts in PRs during some transition period until all 
developers will rebase on the latest version with Scala style checking.

> Fix the loose Scala style check
> -------------------------------
>
>                 Key: HUDI-7222
>                 URL: https://issues.apache.org/jira/browse/HUDI-7222
>             Project: Apache Hudi
>          Issue Type: Task
>          Components: code-quality
>            Reporter: Lin Liu
>            Assignee: Lin Liu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.1.0
>
>
> We have seen the Scala code style is loose for many places, like malformed 
> imports. We have to fix this kind of problem.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to