CTTY commented on code in PR #12847:
URL: https://github.com/apache/hudi/pull/12847#discussion_r1958806353
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1299,6 +1299,10 @@ protected void doInitTable(WriteOperationType
operationType, HoodieTableMetaClie
ownerInstant =
Option.of(metaClient.createNewInstant(HoodieInstant.State.INFLIGHT,
CommitUtils.getCommitActionType(operationType,
metaClient.getTableType()), instantTime.get()));
}
+ boolean requiresInitTable = needsUpgradeOrDowngrade(metaClient) ||
config.isMetadataTableEnabled();
+ if (!requiresInitTable) {
Review Comment:
nit: maybe add a comment like `// short-circuit the transaction if no
upgrade/MDT init is needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
