yihua commented on code in PR #12762:
URL: https://github.com/apache/hudi/pull/12762#discussion_r1960661740
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/KafkaSourceConfig.java:
##########
@@ -167,6 +167,13 @@ public class KafkaSourceConfig extends HoodieConfig {
.withDocumentation("The class name of the Exception that needs to be
retried, separated by commas. "
+ "Default is empty which means retry all the IOException and
RuntimeException from KafkaConsumer");
+ public static final ConfigProperty<Long> OFFSET_SKIP_BUFFER_MINUTES =
ConfigProperty
+ .key(PREFIX + "offset.skip.buffer.minutes")
+ .defaultValue(-1L)
+ .markAdvanced()
+ .withDocumentation("Time in minutes to move forward from retention time
for reading offsets")
+ .sinceVersion("1.1.0");
Review Comment:
nit: to put `.sinceVersion` before `.withDocumentation`
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestKafkaOffsetGen.java:
##########
@@ -80,6 +114,12 @@ private TypedProperties getConsumerConfigs(String
autoOffsetReset, String kafkaC
return props;
}
+ private TypedProperties getConsumerConfigs(String topicName, String
autoOffsetReset, String kafkaCheckpointType) {
+ TypedProperties props = getConsumerConfigs(autoOffsetReset,
kafkaCheckpointType);
+ props.put("hoodie.deltastreamer.source.kafka.topic", topicName);
Review Comment:
```suggestion
props.put("hoodie.streamer.source.kafka.topic", topicName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
