danny0405 commented on code in PR #12796:
URL: https://github.com/apache/hudi/pull/12796#discussion_r1962868025
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/bucket/ITTestBucketStreamWrite.java:
##########
@@ -91,7 +97,20 @@ public void
testBucketStreamWriteAfterRollbackFirstFileGroupCreation(boolean isC
}
}
- private static void doDeleteCommit(String tablePath, boolean isCow) throws
Exception {
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testBucketWriteIntoMultipleBuckets(boolean isCow) throws
Exception {
+ String tablePath = tempFile.getAbsolutePath();
+ doWrite(tablePath, isCow, 2, "upsert");
+ if (isCow) {
+ TestData.checkWrittenDataCOW(tempFile, EXPECTED_LIST);
Review Comment:
> TestData::checkWrittenData expects only one base file
So why there are multiple base files with this patch, Hudi has small file
profiling and only 1 latest base file is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
