Davis-Zhang-Onehouse commented on code in PR #12829:
URL: https://github.com/apache/hudi/pull/12829#discussion_r1964072010
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -369,6 +369,14 @@ public static <T extends SpecificRecordBase> T
convertCommitMetadata(HoodieCommi
return (T) avroMetaData;
}
+ /**
+ * Convert commit metadata from json to avro.
+ */
+ public static HoodieCommitMetadata
convertCommitMetadataAvroToPojo(org.apache.hudi.avro.model.HoodieCommitMetadata
hoodieCommitMetadata) {
+ hoodieCommitMetadata.getPartitionToWriteStats().remove(null);
Review Comment:
done. Thanks for the note.
for POJO I still keep the remove(null) protection based on the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
