yihua commented on code in PR #12858:
URL: https://github.com/apache/hudi/pull/12858#discussion_r1964133956
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/CompletionTimeQueryViewV2.java:
##########
@@ -256,7 +255,7 @@ private List<String> getInstantTimes(
// fallback to archived timeline
return this.instantTimeToCompletionTimeMap.entrySet().stream()
.filter(entry ->
InstantComparison.compareTimestamps(entry.getValue(), LESSER_THAN_OR_EQUALS,
endCompletionTime.get()))
- .map(Map.Entry::getKey).collect(Collectors.toList());
+ .map(Map.Entry::getKey).sorted().collect(Collectors.toList());
Review Comment:
Good catch. The fix makes sense. @danny0405 lmk if you have objection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
