Davis-Zhang-Onehouse commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1964160489
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -258,4 +258,9 @@ public HoodieArchivedTimeline reload() {
public HoodieArchivedTimeline reload(String startTs) {
return new ArchivedTimelineV1(metaClient, startTs);
}
+
+ @Override
+ public boolean isEmpty(HoodieInstant instant) {
+ return TimelineUtils.isEmpty(metaClient, instant);
Review Comment:
yeah, that makes sense, I revised the logic to be the same as before.
Previously they just call getInstantDetails().isEmpty(), where:
- if the instant is already loaded, it reads from the cache and evaluate
- If no, it will load to cache and evaluate.
TimelineUtils.isEmpty does not assume instants are stored in archived
timeline layout and this is a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
