Davis-Zhang-Onehouse commented on code in PR #12781:
URL: https://github.com/apache/hudi/pull/12781#discussion_r1964606250
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieCommitMetadata.java:
##########
@@ -69,6 +70,14 @@ public HoodieCommitMetadata(boolean compacted) {
this.compacted = compacted;
}
+ @VisibleForTesting
+ public HoodieCommitMetadata(HoodieCommitMetadata metadata) {
+ extraMetadata = metadata.getExtraMetadata();
+ partitionToWriteStats = metadata.getPartitionToWriteStats();
+ compacted = metadata.getCompacted();
+ operationType = metadata.getOperationType();
+ }
+
Review Comment:
removed
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable.scala:
##########
@@ -1295,64 +1295,6 @@ class TestMergeIntoTable extends HoodieSparkSqlTestBase
with ScalaAssertionSuppo
})
}
- test("Test partial insert with inline clustering") {
Review Comment:
reverted
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable.scala:
##########
@@ -1490,47 +1432,48 @@ class TestMergeIntoTable extends HoodieSparkSqlTestBase
with ScalaAssertionSuppo
testConfigs.foreach { case (tableType, sparkSqlOptimizedWrites) =>
log.info(s"=== Testing MergeInto with partial insert:
tableType=$tableType, sparkSqlOptimizedWrites=$sparkSqlOptimizedWrites ===")
withRecordType()(withTempDir { tmp =>
- withSparkSqlSessionConfig("hoodie.payload.combined.schema.validate" ->
"true",
- SPARK_SQL_OPTIMIZED_WRITES.key() ->
sparkSqlOptimizedWrites.toString) {
- // Create a partitioned table
- val tableName = generateTableName
- spark.sql(
- s"""
- | create table $tableName (
- | id bigint,
- | name string,
- | price double,
- | ts bigint,
- | dt string
- | ) using hudi
- | tblproperties (
- | type = '$tableType',
- | primaryKey = 'id'
- | )
- | partitioned by(dt)
- | location '${tmp.getCanonicalPath}'
- """.stripMargin)
+ spark.sql("set hoodie.payload.combined.schema.validate = true")
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
