CTTY commented on code in PR #12848:
URL: https://github.com/apache/hudi/pull/12848#discussion_r1966629895
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestAlterTable.scala:
##########
@@ -371,11 +375,9 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
val newLocation2 = spark.sessionState.catalog.getTableMetadata(new
TableIdentifier(newLocTableName))
.properties.get("path")
if (oldLocation2.nonEmpty) {
- // Remove the impact of the schema.
- val oldLocation2Path = new
Path(oldLocation2.get.stripPrefix("file:"))
- val newLocation2Path = new
Path(newLocation2.get.stripPrefix("file:"))
+ // the scheme and authority need to match as well
assertResult(true)(
- newLocation2Path.equals(oldLocation2Path)
+ oldLocation2.get.equals(newLocation2.get)
Review Comment:
This is the key change in test, we want to ensure the path won't change even
with the scheme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
