danny0405 commented on code in PR #12867:
URL: https://github.com/apache/hudi/pull/12867#discussion_r1966940157
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/TableCommand.java:
##########
@@ -149,7 +150,7 @@ public String createTable(
try {
HoodieTableMetaClient.builder().setConf(HoodieCLI.conf.newInstance()).setBasePath(path).build();
existing = true;
- } catch (TableNotFoundException dfe) {
+ } catch (TableNotFoundException | InvalidTableException dfe) {
Review Comment:
The checked exception is hard to maintain in code, you don't expect
developer to catch 2 checked exceptions every time initialing the meta client,
no one can follow the rules. How about we just strengthen the error msgs first
for the timeline layout.
As for the exception throwing, maybe we should switch to RuntimeException
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
