vinishjail97 commented on code in PR #12878:
URL: https://github.com/apache/hudi/pull/12878#discussion_r1968480794
##########
hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java:
##########
@@ -203,6 +203,9 @@ public int getFileSlicesCount() {
@Override
public void close() throws Exception {
+ if (cachedAllInputFileSlices instanceof ExternalSpillableMap) {
Review Comment:
@yihua I wasn't able to confirm if this close is actually being called from
the unit test for hoodie spark data sources on the read side. Is it a known gap
?
https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieHadoopFsRelationFactory.scala#L260C3-L260C11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
