yihua commented on code in PR #12741:
URL: https://github.com/apache/hudi/pull/12741#discussion_r1970719814
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String>
BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
Review Comment:
```suggestion
.key("hoodie.bloom.index.fileid.key.sort.partitioner")
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String>
BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
+ .defaultValue("false")
+ .markAdvanced()
+ .withDocumentation("Only applies if index type is BLOOM. "
+ + "When true, fileId and key sort based partitioning is enabled "
+ + "This reduces skew seen in bucket based bloom index lookup");
Review Comment:
```suggestion
.withDocumentation("Only applies if index type is BLOOM. "
+ "When true, the global sorting based on the fileId and key is
enabled during key lookup. "
+ "This reduces skew in the key lookup in the bloom index.");
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String>
BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
+ .defaultValue("false")
+ .markAdvanced()
Review Comment:
add `.sinceVersion`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
