yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1971004850
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/CommitsCommand.java:
##########
@@ -71,20 +72,19 @@ private String printCommits(HoodieTimeline timeline,
.getInstantsAsStream().sorted(instantComparator.requestedTimeOrderedComparator().reversed()).collect(Collectors.toList());
for (final HoodieInstant commit : commits) {
- if (timeline.getInstantDetails(commit).isPresent()) {
- final HoodieCommitMetadata commitMetadata =
HoodieCLI.getTableMetaClient().getCommitMetadataSerDe().deserialize(
- commit,
- timeline.getInstantDetails(commit).get(),
- HoodieCommitMetadata.class);
- rows.add(new Comparable[] {commit.requestedTime(),
- commitMetadata.fetchTotalBytesWritten(),
- commitMetadata.fetchTotalFilesInsert(),
- commitMetadata.fetchTotalFilesUpdated(),
- commitMetadata.fetchTotalPartitionsWritten(),
- commitMetadata.fetchTotalRecordsWritten(),
- commitMetadata.fetchTotalUpdateRecordsWritten(),
- commitMetadata.fetchTotalWriteErrors()});
- }
+ CommitMetadataSerDe serDe =
HoodieCLI.getTableMetaClient().getCommitMetadataSerDe();
+ final HoodieCommitMetadata commitMetadata = serDe.deserialize(
Review Comment:
Inline the serDe
```suggestion
final HoodieCommitMetadata commitMetadata =
HoodieCLI.getTableMetaClient().getCommitMetadataSerDe().deserialize(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
