CTTY commented on code in PR #12873:
URL: https://github.com/apache/hudi/pull/12873#discussion_r1972122928
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1510,12 +1510,20 @@ public void performTableServices(Option<String>
inFlightInstantTimestamp, boolea
allTableServicesExecutedSuccessfullyOrSkipped = false;
throw e;
} finally {
+ String tableName = writeClient.getConfig().getTableName();
+ boolean tableNameExists = StringUtils.nonEmpty(tableName);
+ String executionDurationMetricName = tableNameExists
+ ? String.format("%s.%s", tableName,
HoodieMetadataMetrics.TABLE_SERVICE_EXECUTION_DURATION)
Review Comment:
I don't see other metrics reporter require `tableName` in the dimensions so
they should be ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
