yihua commented on code in PR #12798:
URL: https://github.com/apache/hudi/pull/12798#discussion_r1972631489
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeModeEventTimeOrdering.scala:
##########
@@ -30,7 +30,7 @@ import
org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase.validateTableConf
class TestMergeModeEventTimeOrdering extends HoodieSparkSqlTestBase {
// TODO(HUDI-8938): add "mor,6,true", "mor,6,false" after the fix
- Seq("cow,8,true", "cow,8,false", "cow,6,true", "cow,6,false",
+ Seq(
Review Comment:
Revert
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable2.scala:
##########
@@ -1168,7 +1168,7 @@ class TestMergeIntoTable2 extends HoodieSparkSqlTestBase {
withRecordType()(withTempDir { tmp =>
Seq("cow", "mor").foreach { tableType =>
Seq("COMMIT_TIME_ORDERING", "EVENT_TIME_ORDERING").foreach { mergeMode
=>
-
withSparkSqlSessionConfig(DataSourceWriteOptions.ENABLE_MERGE_INTO_PARTIAL_UPDATES.key
-> "false") {
+
withSparkSqlSessionConfig(DataSourceWriteOptions.ENABLE_MERGE_INTO_PARTIAL_UPDATES.key
-> "true") {
Review Comment:
`false` is already covered by `Test MergeInto Anti-Patterns of assignment
clauses`, which is why it is changed to `true` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
