voonhous commented on code in PR #12794:
URL: https://github.com/apache/hudi/pull/12794#discussion_r1973253947
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestCompactionProcedure.scala:
##########
@@ -360,7 +360,7 @@ class TestCompactionProcedure extends
HoodieSparkProcedureTestBase {
val conf = new Configuration
val metaClient = HoodieTestUtils.createMetaClient(new
HadoopStorageConfiguration(conf), basePath)
- assert(0 ==
metaClient.getActiveTimeline.getCompletedReplaceTimeline.getInstants.size())
+
assert(metaClient.getActiveTimeline.getCompletedReplaceTimeline.getInstants.size()
== 0)
Review Comment:
Swapping the RHS and LHS here as scalatest's assert will use the RHS as
"expected", while the LHS is "actual".
It's an OCD thing, but test hints will look correct when there are errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
