lokeshj1703 commented on code in PR #12888:
URL: https://github.com/apache/hudi/pull/12888#discussion_r1976388442
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java:
##########
@@ -281,13 +281,6 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
final String instantTime =
logBlock.getLogBlockHeader().get(INSTANT_TIME);
totalLogBlocks.incrementAndGet();
if (logBlock.isDataOrDeleteBlock()) {
- if (this.tableVersion.lesserThan(HoodieTableVersion.EIGHT)) {
- if
(!getOrCreateCompletedInstantsTimeline().containsOrBeforeTimelineStarts(instantTime)
- ||
getOrCreateInflightInstantsTimeline().containsInstant(instantTime)) {
Review Comment:
Fixed the usage. Now these checks are not made for RLI.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java:
##########
@@ -479,13 +472,6 @@ &&
compareTimestamps(logBlock.getLogBlockHeader().get(INSTANT_TIME), GREATER_THA
continue;
}
if (logBlock.getBlockType() != COMMAND_BLOCK) {
- if (this.tableVersion.lesserThan(HoodieTableVersion.EIGHT)) {
- if
(!getOrCreateCompletedInstantsTimeline().containsOrBeforeTimelineStarts(instantTime)
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
