yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1975953727
##########
hudi-common/src/main/java/org/apache/hudi/common/util/CommitUtils.java:
##########
@@ -127,10 +127,7 @@ private static HoodieCommitMetadata
buildMetadataFromStats(List<HoodieWriteStat>
public static Option<HoodieCommitMetadata>
buildMetadataFromInstant(HoodieTimeline timeline, HoodieInstant instant) {
try {
- TimelineLayout layout =
TimelineLayout.fromVersion(timeline.getTimelineLayoutVersion());
- HoodieCommitMetadata commitMetadata =
layout.getCommitMetadataSerDe().deserialize(instant,
- timeline.getInstantDetails(instant).get(),
- HoodieCommitMetadata.class);
+ HoodieCommitMetadata commitMetadata =
timeline.loadInstantContent(instant, HoodieCommitMetadata.class);
Review Comment:
Let's add an API `readCommitMetadata(HoodieInstant instant)` to return
`HoodieCommitMetadata` directly so `loadInstantContent` with clazz is not
called here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
