leesf commented on a change in pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#discussion_r505541446
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java
##########
@@ -129,6 +131,18 @@ private int addUpdateBucket(String partitionPath, String
fileIdHint) {
return bucket;
}
+ private int addInsertBucket(String partitionPath, String fileIdHint) {
+ int bucket = totalBuckets;
+ updateLocationToBucket.put(fileIdHint, bucket);
+ BucketInfo bucketInfo = new BucketInfo();
+ bucketInfo.bucketType = BucketType.INSERT;
+ bucketInfo.fileIdPrefix = fileIdHint;
+ bucketInfo.partitionPath = partitionPath;
+ bucketInfoMap.put(totalBuckets, bucketInfo);
+ totalBuckets++;
+ return bucket;
Review comment:
would also merge
``` java
for (int b = 0; b < insertBuckets; b++) {
bucketNumbers.add(totalBuckets);
recordsPerBucket.add(totalUnassignedInserts / insertBuckets);
BucketInfo bucketInfo = new BucketInfo();
bucketInfo.bucketType = BucketType.INSERT;
bucketInfo.partitionPath = partitionPath;
bucketInfo.fileIdPrefix = FSUtils.createNewFileIdPfx();
bucketInfoMap.put(totalBuckets, bucketInfo);
totalBuckets++;
}
```
the logic to the method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
