yihua commented on code in PR #12781:
URL: https://github.com/apache/hudi/pull/12781#discussion_r1980674634
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestConcurrentSchemaEvolutionTableSchemaGetter.java:
##########
@@ -278,19 +262,16 @@ private void
addCommitOrDeltaCommitWithSchema(HoodieTableType tableType, String
private static Stream<Arguments> commonTableConfigTestDimension() {
return Stream.of(
- // version 6 or 8, tableType
- Arguments.of(true, HoodieTableType.COPY_ON_WRITE),
- Arguments.of(true, HoodieTableType.MERGE_ON_READ),
- Arguments.of(false, HoodieTableType.COPY_ON_WRITE),
- Arguments.of(false, HoodieTableType.MERGE_ON_READ)
+ Arguments.of(HoodieTableType.COPY_ON_WRITE),
+ Arguments.of(HoodieTableType.MERGE_ON_READ)
);
}
@ParameterizedTest
@MethodSource("commonTableConfigTestDimension")
- void testGetTableAvroSchemaInternalNoSchemaFoundEmptyTimeline(boolean
enableMetadata, HoodieTableType tableType) throws IOException {
+ void
testGetTableAvroSchemaInternalNoSchemaFoundEmptyTimeline(HoodieTableType
tableType) throws IOException {
// Don't set any schema in commit metadata or table config
- initMetaClient(enableMetadata, tableType);
Review Comment:
`enableMetadata`: just realized that this is not for MDT but rather table
version. Since we only want to support table version 8, this is removed.
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestConcurrentSchemaEvolutionTableSchemaGetter.java:
##########
@@ -278,19 +262,16 @@ private void
addCommitOrDeltaCommitWithSchema(HoodieTableType tableType, String
private static Stream<Arguments> commonTableConfigTestDimension() {
return Stream.of(
- // version 6 or 8, tableType
- Arguments.of(true, HoodieTableType.COPY_ON_WRITE),
- Arguments.of(true, HoodieTableType.MERGE_ON_READ),
- Arguments.of(false, HoodieTableType.COPY_ON_WRITE),
- Arguments.of(false, HoodieTableType.MERGE_ON_READ)
+ Arguments.of(HoodieTableType.COPY_ON_WRITE),
+ Arguments.of(HoodieTableType.MERGE_ON_READ)
);
}
@ParameterizedTest
@MethodSource("commonTableConfigTestDimension")
- void testGetTableAvroSchemaInternalNoSchemaFoundEmptyTimeline(boolean
enableMetadata, HoodieTableType tableType) throws IOException {
+ void
testGetTableAvroSchemaInternalNoSchemaFoundEmptyTimeline(HoodieTableType
tableType) throws IOException {
// Don't set any schema in commit metadata or table config
- initMetaClient(enableMetadata, tableType);
Review Comment:
In the write config, we may want to mention that the schema conflict
resolution only works on table version 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
