yihua commented on code in PR #12943:
URL: https://github.com/apache/hudi/pull/12943#discussion_r1986195184
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCleanConfig.java:
##########
@@ -77,9 +98,9 @@ public class HoodieCleanConfig extends HoodieConfig {
.withDocumentation(HoodieCleaningPolicy.class)
.markAdvanced()
.withInferFunction(cfg -> {
- boolean isCommitsRetainedConfigured =
cfg.contains(CLEANER_COMMITS_RETAINED_KEY);
- boolean isHoursRetainedConfigured =
cfg.contains(CLEANER_HOURS_RETAINED_KEY);
- boolean isFileVersionsRetainedConfigured =
cfg.contains(CLEANER_FILE_VERSIONS_RETAINED_KEY);
+ boolean isCommitsRetainedConfigured =
cfg.contains(CLEANER_COMMITS_RETAINED.key()) ||
CLEANER_COMMITS_RETAINED.getAlternatives().stream().anyMatch(cfg::contains);
+ boolean isHoursRetainedConfigured =
cfg.contains(CLEANER_HOURS_RETAINED.key()) ||
CLEANER_HOURS_RETAINED.getAlternatives().stream().anyMatch(cfg::contains);
+ boolean isFileVersionsRetainedConfigured =
cfg.contains(CLEANER_FILE_VERSIONS_RETAINED.key()) ||
CLEANER_FILE_VERSIONS_RETAINED.getAlternatives().stream().anyMatch(cfg::contains);
Review Comment:
nit: directly use `cfg.contains(CLEANER_COMMITS_RETAINED)` which takes
`ConfigProperty` as an argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
