yihua commented on code in PR #12959:
URL: https://github.com/apache/hudi/pull/12959#discussion_r1991192030
##########
packaging/bundle-validation/validate.sh:
##########
@@ -376,7 +376,7 @@ if [ "$?" -ne 0 ]; then
fi
echo "::warning::validate.sh done validating utilities slim bundle"
-if [[ ${JAVA_RUNTIME_VERSION} == 'openjdk8' && ${SCALA_PROFILE} !=
'scala-2.13' && ! "${FLINK_HOME}" == *"1.18"* ]]; then
+if [[ ${JAVA_RUNTIME_VERSION} == 'openjdk8' && ${SCALA_PROFILE} !=
'scala-2.13' ]]; then
Review Comment:
While the change looks good, the Flink bundle validation is still not
executed on Flink 1.18, as the corresponding bundle validation profile is
coupled with `scala-2.13` (and I don’t see Flink bundle validation success
message in GH CI). Could you try adding or changing a profile to let Flink 1.18
bundle validation run and see if it succeeds?
```
- scalaProfile: 'scala-2.13'
flinkProfile: 'flink1.18'
flinkAvroVersion: '1.11.1'
sparkProfile: 'spark3.5'
sparkRuntime: 'spark3.5.1'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
