yihua commented on code in PR #12952:
URL: https://github.com/apache/hudi/pull/12952#discussion_r1991205186
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -235,11 +235,15 @@ protected void commit(HoodieWriteMetadata<O> result,
List<HoodieWriteStat> write
LOG.info("Committed " + instantTime);
result.setCommitMetadata(Option.of(metadata));
// update cols to Index as applicable
- HoodieColumnStatsIndexUtils.updateColsToIndex(table, config, metadata,
- (Functions.Function2<HoodieTableMetaClient, List<String>, Void>)
(metaClient, columnsToIndex) -> {
- updateColumnsToIndexForColumnStats(metaClient, columnsToIndex);
- return null;
- });
+ try {
+ HoodieColumnStatsIndexUtils.updateColsToIndex(table, config, metadata,
+ (Functions.Function2<HoodieTableMetaClient, List<String>,
Void>) (metaClient, columnsToIndex) -> {
+ updateColumnsToIndexForColumnStats(metaClient,
columnsToIndex);
+ return null;
+ });
+ } catch (UnsupportedOperationException uoe) {
Review Comment:
Could we catch a specific exception for bootstrap here?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -235,11 +235,15 @@ protected void commit(HoodieWriteMetadata<O> result,
List<HoodieWriteStat> write
LOG.info("Committed " + instantTime);
result.setCommitMetadata(Option.of(metadata));
// update cols to Index as applicable
- HoodieColumnStatsIndexUtils.updateColsToIndex(table, config, metadata,
- (Functions.Function2<HoodieTableMetaClient, List<String>, Void>)
(metaClient, columnsToIndex) -> {
- updateColumnsToIndexForColumnStats(metaClient, columnsToIndex);
- return null;
- });
+ try {
+ HoodieColumnStatsIndexUtils.updateColsToIndex(table, config, metadata,
+ (Functions.Function2<HoodieTableMetaClient, List<String>,
Void>) (metaClient, columnsToIndex) -> {
+ updateColumnsToIndexForColumnStats(metaClient,
columnsToIndex);
+ return null;
+ });
+ } catch (UnsupportedOperationException uoe) {
Review Comment:
Have you checked that there is no failed deltacommit in MDT this case and
files partition is intact, and the index ready to use does not contain
col_stats in the table config?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -235,11 +235,15 @@ protected void commit(HoodieWriteMetadata<O> result,
List<HoodieWriteStat> write
LOG.info("Committed " + instantTime);
result.setCommitMetadata(Option.of(metadata));
// update cols to Index as applicable
- HoodieColumnStatsIndexUtils.updateColsToIndex(table, config, metadata,
- (Functions.Function2<HoodieTableMetaClient, List<String>, Void>)
(metaClient, columnsToIndex) -> {
- updateColumnsToIndexForColumnStats(metaClient, columnsToIndex);
- return null;
- });
+ try {
+ HoodieColumnStatsIndexUtils.updateColsToIndex(table, config, metadata,
+ (Functions.Function2<HoodieTableMetaClient, List<String>,
Void>) (metaClient, columnsToIndex) -> {
+ updateColumnsToIndexForColumnStats(metaClient,
columnsToIndex);
+ return null;
+ });
+ } catch (UnsupportedOperationException uoe) {
+ LOG.warn("Failed to update col stats, bootstrap doesn't support col
stats", uoe);
Review Comment:
```suggestion
LOG.warn("Skip updating column stats index in the metadata table for
bootstrap operation because it is not supported", uoe);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
