codope commented on code in PR #12953:
URL: https://github.com/apache/hudi/pull/12953#discussion_r1993611357
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -410,8 +411,9 @@ public static Map<String, HoodieData<HoodieRecord>>
convertMetadataToRecords(Hoo
checkState(MetadataPartitionType.COLUMN_STATS.isMetadataPartitionAvailable(dataMetaClient),
"Column stats partition must be enabled to generate partition stats.
Please enable: " +
HoodieMetadataConfig.ENABLE_METADATA_INDEX_COLUMN_STATS.key());
// Generate Hoodie Pair data of partition name and list of column range
metadata for all the files in that partition
+ boolean isDeletePartition =
commitMetadata.getOperationType().equals(WriteOperationType.DELETE_PARTITION);
Review Comment:
Agree, created HUDI-8714 as followup. I think we can land this PR as files
and partition stats are used in partition pruning so these indexes need to be
strongly consistent. Column stats can be eventually consistent (update when
replaced filegroups are cleaned) as colstats is used in data skipping after
partition pruning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
