TheR1sing3un commented on code in PR #12949:
URL: https://github.com/apache/hudi/pull/12949#discussion_r1988900640
##########
style/checkstyle.xml:
##########
@@ -270,7 +270,7 @@
<module name="IllegalImport">
<property name="regexp" value="true"/>
<property name="illegalPkgs"
- value="org\.apache\.commons, com\.google\.common,
org\.apache\.log4j, org\.codehaus\.jackson"/>
+ value="org\.apache\.commons, org\.apache\.log4j,
org\.codehaus\.jackson"/>
Review Comment:
> It looks like the guava cache is forbidden, we can switch to caffeine
cache.
I tried to replace guava with caffeine, but I found that the
`caffeine::Interner` class is available only in versions 3.0 and above, but 3.x
does not support java8. So maybe we should keep importing guava.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
