[ 
https://issues.apache.org/jira/browse/HUDI-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217868#comment-17217868
 ] 

Vinoth Chandar commented on HUDI-89:
------------------------------------

> We are not looking for a full fledged ConfigOption(which include fallback 
> keys and and stuff), but just key, value, defaultValue and description for now

why are we making this assumption? I think we should do it such that there is 
support for fallback keys. 

 

>And btw, with this change, we also want to rename HoodieWriteConfig to 
>HoodieClientConfig. 

+1 

 

> may I know how do we go about populating ConfigOptions from a map of 
> properties or from a property file.

the value type must be part of the ConfigOption IMO. if we parse a prop file, 
then we try to parse the value as that type 

> Clean up placement, naming, defaults of HoodieWriteConfig
> ---------------------------------------------------------
>
>                 Key: HUDI-89
>                 URL: https://issues.apache.org/jira/browse/HUDI-89
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: Code Cleanup, Usability, Writer Core
>            Reporter: Vinoth Chandar
>            Assignee: Vinoth Chandar
>            Priority: Major
>
> # Rename HoodieWriteConfig to HoodieClientConfig 
>  # Move bunch of configs from  CompactionConfig to StorageConfig 
>  # Introduce new HoodieCleanConfig
>  # Should we consider lombok or something to automate the 
> defaults/getters/setters
>  # Consistent name of properties/defaults 
>  # Enforce bounds more strictly 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to