nsivabalan commented on code in PR #12977:
URL: https://github.com/apache/hudi/pull/12977#discussion_r1996126118
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1597,10 +1597,9 @@ private static Map<String, Schema>
getColumnsToIndexWithoutRequiredMetaFields(Ho
tableSchemaLazyOpt.get().map(schema -> getFirstNSupportedFields(schema,
metadataConfig.maxColumnsToIndexForColStats(),
recordType)).orElse(Stream.empty())
.forEach(entry -> colsToIndexSchemaMap.put(entry.getKey(),
entry.getValue()));
return colsToIndexSchemaMap;
- } else if (isTableInitializing) {
- return Collections.emptyMap();
} else {
- throw new HoodieMetadataException("Cannot initialize col stats with
empty list of cols");
+ // initialize col stats index config with empty list of cols
+ return Collections.emptyMap();
Review Comment:
can we add tests for this case
##########
hudi-common/src/main/java/org/apache/hudi/common/model/ActionType.java:
##########
@@ -22,5 +22,18 @@
* The supported action types.
*/
public enum ActionType {
- commit, savepoint, compaction, clean, rollback, replacecommit, deltacommit,
logcompaction, clustering
+ commit,
+ savepoint,
+ compaction,
+ clean,
+ rollback,
+ replacecommit,
+ deltacommit,
+ logcompaction,
+ clustering;
+
+ public static boolean isCommitActionType(String actionTypeStr) {
Review Comment:
can we add tests for this `isCommitActionType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
