danny0405 commented on code in PR #12967: URL: https://github.com/apache/hudi/pull/12967#discussion_r1999942832
########## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/FlinkRowDataWriteClient.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.client; + +import org.apache.hudi.io.v2.HandleRecords; +import org.apache.hudi.table.action.commit.BucketInfo; + +import java.util.List; + +/** + * Interface for flink write client that supports writing RowData directly into the underneath filesystem. + * <p> + * todo: add support for Insert/InsertOverwrite/InsertOverwriteTable, see HUDI-9075 + */ +public interface FlinkRowDataWriteClient { + + /** + * Upsert a batch of new records into Hoodie table at the supplied instantTime. + * + * @param records rowdatas needed to be written, in form of iterator + * @param bucketInfo the bucket info for the target bucket + * @param instantTime instant time to commit the data + * @return Collection of WriteStatus to inspect errors and counts + */ + List<WriteStatus> upsert(HandleRecords records, BucketInfo bucketInfo, String instantTime); Review Comment: Not sure about the `HandleRecords` abstraction and why `BucketInfo bucketInfo` is required for the write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
