yihua commented on code in PR #12984:
URL: https://github.com/apache/hudi/pull/12984#discussion_r2002015927
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -541,6 +541,66 @@ class TestMORDataSource extends HoodieSparkClientTestBase
with SparkDatasetMixin
assertEquals(0, hudiSnapshotDF3.count()) // 100 records were deleted, 0
record to load
}
+ @Test
+ def testDeletesWithLowerOrderingValue() : Unit = {
Review Comment:
Should this test be added to `TestRecordLevelIndex` since it's record index
specific?
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/testutils/DataSourceTestUtils.java:
##########
@@ -130,13 +133,24 @@ public static List<Row>
generateRandomRowsEvolvedSchema(int count) {
}
public static List<Row> updateRowsWithHigherTs(Dataset<Row> inputDf) {
+ return updateRowsWithUpdatedTs(inputDf, false, false);
+ }
+
+ public static List<Row> updateRowsWithUpdatedTs(Dataset<Row> inputDf,
Boolean lowerTs, Boolean updatePartitionPath) {
List<Row> input = inputDf.collectAsList();
List<Row> rows = new ArrayList<>();
for (Row row : input) {
- Object[] values = new Object[3];
+ Object[] values = new Object[4];
Review Comment:
The changes should already be merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
