danny0405 commented on code in PR #12967:
URL: https://github.com/apache/hudi/pull/12967#discussion_r2002861195


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/DataTypeUtils.java:
##########
@@ -167,4 +169,73 @@ public static DataType ensureColumnsAsNonNullable(DataType 
dataType, @Nullable L
     return 
DataTypes.ROW(fields.stream().toArray(DataTypes.Field[]::new)).notNull();
   }
 
+  /**
+   * Adds the Hoodie metadata fields to the given row type.
+   */
+  public static RowType addMetadataFields(
+      RowType rowType,
+      boolean withOperationField) {
+    return addMetadataFields(rowType, true, true, withOperationField);
+  }
+
+  /**
+   * Adds the Hoodie metadata fields to the given row type.
+   */
+  public static RowType addMetadataFields(
+      RowType rowType,
+      boolean isPopulateMetaFields,
+      boolean includeInstant,

Review Comment:
   Not sure we need this `includeInstant` flag.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to