vinothchandar commented on a change in pull request #2106:
URL: https://github.com/apache/hudi/pull/2106#discussion_r509909517
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkUpsertCommitActionExecutor.java
##########
@@ -44,6 +45,7 @@ public
SparkUpsertCommitActionExecutor(HoodieSparkEngineContext context,
@Override
public HoodieWriteMetadata<JavaRDD<WriteStatus>> execute() {
return SparkWriteHelper.newInstance().write(instantTime, inputRecordsRDD,
context, table,
- config.shouldCombineBeforeUpsert(),
config.getUpsertShuffleParallelism(), this, true);
+ config.shouldCombineBeforeUpsert(),
config.getUpsertShuffleParallelism(),
Review comment:
when the delta streamer say is run with this code, it will pass the
schema in and end up calling the preCombine(payload, schema) method. but it may
not be present on the older payload implementations. This is tricky. but we
need to find a way to not have this break.. any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
