nsivabalan commented on code in PR #13020:
URL: https://github.com/apache/hudi/pull/13020#discussion_r2010392608
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/SevenToEightUpgradeHandler.java:
##########
@@ -192,6 +192,14 @@ static void upgradeMergeMode(HoodieTableConfig
tableConfig, Map<ConfigProperty,
HoodieTableConfig.RECORD_MERGE_MODE,
RecordMergeMode.EVENT_TIME_ORDERING.name());
}
+ } else if (tableConfig.getPayloadClass() != null
+ &&
tableConfig.getPayloadClass().equals(DefaultHoodieRecordPayload.class.getName()))
{
Review Comment:
@linliu-code already has a fix towards this.
https://github.com/apache/hudi/pull/13009
can we remove those changes in this patch.
in tests, we can use DefaultHoodieRecordPayload for now to avoid hitting
this
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -426,6 +427,130 @@ class TestMORDataSource extends HoodieSparkClientTestBase
with SparkDatasetMixin
}
}
+ @Test
+ def testUpgradeDowngradeWithRecordIndex() : Unit = {
Review Comment:
we can just have 1 patch for this and mdt compaction fix. and have just 1
test for both cases. looking to avoid adding more tests, if we could achieve in
a single test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
