danny0405 commented on code in PR #13017:
URL: https://github.com/apache/hudi/pull/13017#discussion_r2009640130
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/BucketIndexBulkInsertPartitionerWithRows.java:
##########
@@ -31,15 +35,29 @@ public class BucketIndexBulkInsertPartitionerWithRows
implements BulkInsertParti
private final String indexKeyFields;
private final int bucketNum;
+ private boolean isPartitionBucketIndexEnable = false;
+ private PartitionBucketIndexCalculator calc;
- public BucketIndexBulkInsertPartitionerWithRows(String indexKeyFields, int
bucketNum) {
+ public BucketIndexBulkInsertPartitionerWithRows(String indexKeyFields, int
bucketNum, HoodieTable table) {
this.indexKeyFields = indexKeyFields;
this.bucketNum = bucketNum;
+ String hashingInstantToLoad =
table.getConfig().getHashingConfigInstantToLoad();
Review Comment:
Like avobe-mentioned, we should not bind the index config with table config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
