cshuo commented on code in PR #13027:
URL: https://github.com/apache/hudi/pull/13027#discussion_r2011408905
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -1129,9 +1113,9 @@ void testWriteLocalIndex() {
assertRowsEquals(result, expected, 3);
}
- @Test
- void testStreamReadEmptyTablePath() throws Exception {
- // case1: table metadata path does not exists
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ void testStreamReadEmptyTablePath(boolean initTable) throws Exception {
Review Comment:
For the previous code, sometimes tm resources are not released after case1
canceled, which lead to unexpected failure of case2. The change here is to make
sure a new `TableEnvironment` is created for testing every case, and enhance
the stability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
