danny0405 commented on code in PR #13017:
URL: https://github.com/apache/hudi/pull/13017#discussion_r2011794863
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLayoutConfig.java:
##########
@@ -92,7 +96,13 @@ private void setDefault() {
// Currently, the partitioner of the SIMPLE bucket index is supported
by SparkBucketIndexPartitioner only.
if
("SIMPLE".equals(layoutConfig.getString(HoodieIndexConfig.BUCKET_INDEX_ENGINE_TYPE)))
{
- layoutConfig.setDefaultValue(LAYOUT_PARTITIONER_CLASS_NAME,
SIMPLE_BUCKET_LAYOUT_PARTITIONER_CLASS_NAME);
+ if
(StringUtils.nonEmpty(layoutConfig.getString(HoodieIndexConfig.BUCKET_INDEX_PARTITION_EXPRESSIONS)))
{
+ // partition level simple bucket index
+ layoutConfig.setDefaultValue(LAYOUT_PARTITIONER_CLASS_NAME,
PARTITION_SIMPLE_BUCKET_LAYOUT_PARTITIONER_CLASS_NAME);
Review Comment:
Maybe we name it `PARTITION_BUCKET_LAYOUT_PARTITIONER_CLASS_NAME`, and the
simple bucket index is deemed as a special case of partition bucket index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
