nsivabalan commented on code in PR #9794:
URL: https://github.com/apache/hudi/pull/9794#discussion_r2012713383
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -1471,6 +1473,7 @@ public Properties build() {
}
if (null != commitTimeZone) {
tableConfig.setValue(HoodieTableConfig.TIMELINE_TIMEZONE,
commitTimeZone.toString());
+ HoodieInstantTimeGenerator.setCommitTimeZone(commitTimeZone);
Review Comment:
is there a way we can avoid expecting caller to call
`HoodieInstantTimeGenerator.setCommitTimeZone` everytime.
for eg,
whenever we set tableConfig.setTimeZone, or whenever we build the
tableConfig (while creating or updating), can we call
`HoodieInstantTimeGenerator.setCommitTimeZone` internally.
so that every caller does not need to worry about calling this api w/o miss.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngradeUtils.java:
##########
@@ -211,4 +211,11 @@ static void rollbackFailedWritesAndCompact(HoodieTable
table, HoodieEngineContex
throw new HoodieException(e);
}
}
+
+ static String getTimelineTimezone(HoodieTableConfig tableConfig) {
+ if (tableConfig.getTimelineTimezone() != null) {
Review Comment:
but if we are executing this piece of code which is going to be in 1.0.2
release, wouldn't the default value kick in automatically from the in memory
default value.
even though hoodie.properties may not contain it for table version 6 table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
