danny0405 commented on code in PR #13026:
URL: https://github.com/apache/hudi/pull/13026#discussion_r2013072421
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -615,9 +615,13 @@ object HoodieFileIndex extends Logging {
}
// if database name is not set, fall back to use 'default' instead of failing
- def getDatabaseName(tableConfig: HoodieTableConfig) = {
+ def getDatabaseName(tableConfig: HoodieTableConfig, defaultDatabase: String)
= {
Review Comment:
in line 541 can we just make sure the default data base is never null, and
in this method always use the passed default database as a fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
