danny0405 commented on code in PR #12866:
URL: https://github.com/apache/hudi/pull/12866#discussion_r2013435415
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndex.java:
##########
@@ -144,7 +144,7 @@ public BootstrapIndex.IndexReader createReader() {
@Override
public BootstrapIndex.IndexWriter createWriter(String bootstrapBasePath) {
- return (IndexWriter)
ReflectionUtils.loadClass("org.apache.hudi.common.bootstrap.index.hfile.HBaseHFileBootstrapIndexWriter",
+ return (IndexWriter)
ReflectionUtils.loadClass("org.apache.hudi.common.bootstrap.index.hfile.HFileBootstrapIndexWriter",
Review Comment:
Can we avoid to hard code the class name, `HFileBootstrapIndexWriter` is
visible to this class in compile time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]