linliu-code commented on code in PR #12866:
URL: https://github.com/apache/hudi/pull/12866#discussion_r2014878527


##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -196,15 +189,11 @@ public void close() {
   @Override
   public void begin() {
     try {
-      HFileContext meta = new HFileContextBuilder().withCellComparator(new 
org.apache.hudi.common.bootstrap.index.HFileBootstrapIndex.HoodieKVComparator()).build();
-      this.indexByPartitionWriter = 
HFile.getWriterFactory(metaClient.getStorageConf().unwrapAs(Configuration.class),
-              new 
CacheConfig(metaClient.getStorageConf().unwrapAs(Configuration.class)))
-          .withPath((FileSystem) metaClient.getStorage().getFileSystem(), new 
Path(indexByPartitionPath.toUri()))
-          .withFileContext(meta).create();
-      this.indexByFileIdWriter = 
HFile.getWriterFactory(metaClient.getStorageConf().unwrapAs(Configuration.class),
-              new 
CacheConfig(metaClient.getStorageConf().unwrapAs(Configuration.class)))
-          .withPath((FileSystem) metaClient.getStorage().getFileSystem(), new 
Path(indexByFileIdPath.toUri()))
-          .withFileContext(meta).create();
+      HFileContext context = HFileContext.builder().build();

Review Comment:
   Previously I don't add support for compressionCodec. Now I can add support 
for compression. Block size can also be tuned if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to