danny0405 commented on code in PR #13027:
URL: https://github.com/apache/hudi/pull/13027#discussion_r2015150239
##########
hudi-io/src/main/java/org/apache/hudi/storage/HoodieStorage.java:
##########
@@ -389,7 +389,10 @@ public final void createImmutableFileInPath(StoragePath
path,
*/
@PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING)
public final boolean needCreateTempFile() {
- return StorageSchemes.HDFS.getScheme().equals(getScheme());
+ return StorageSchemes.HDFS.getScheme().equals(getScheme())
+ // Local file will be visible immediately after
LocalFileSystem#create(..), even before the output
+ // stream is closed, so temporary file is also needed for atomic file
creating with content written.
+ || StorageSchemes.FILE.getScheme().equals(getScheme());
Review Comment:
Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
