danny0405 commented on code in PR #13037:
URL: https://github.com/apache/hudi/pull/13037#discussion_r2015171480
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -271,6 +272,10 @@ private static Object toEpochMilli(Object val,
TimestampBasedAvroKeyGenerator ke
// should match the default partition path when STRING partition path
re-format is supported
return keyGenerator.getDefaultPartitionVal();
}
+ if (val instanceof StringData) {
+ // case of `TimestampType.DATE_STRING`, need to convert to string for
consequent processing in `hudi-client-common` module
+ return val.toString();
Review Comment:
do we have a test case to cover this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
