geserdugarov commented on PR #13032: URL: https://github.com/apache/hudi/pull/13032#issuecomment-2757888697
@yihua , @codope , @nsivabalan , I've also spent some time on this flaky test before I found this PR. I propose to clarify the situation with this UT by merge of: https://github.com/apache/hudi/pull/13042 I've added clarification in the comment in this test: ```text // Note, that `metaClient` is initialized here with default `HoodieTimeGeneratorConfig#timeGeneratorConfig`, // which means that `HoodieTimeGeneratorConfig#MAX_EXPECTED_CLOCK_SKEW_MS` with default value will be used (probably, it's 200 ms). // It leads to corresponding thread sleep in `SkewAdjustingTimeGenerator::generateTime` for each call // after all preliminary initialization costs in the following loop, so we don't want to iterate a lot here. ``` and reduced number of iterations and max permitted diff. We don't need to retry so much in unit test. I couldn't configure properly this case from `TestHoodieTableMetaClient` because of current test classes inheritance, but checked locally, that if I change default value of `HoodieTimeGeneratorConfig#MAX_EXPECTED_CLOCK_SKEW_MS` to 1 ms, then I could set `i < 100` without any failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
