danny0405 commented on code in PR #13017:
URL: https://github.com/apache/hudi/pull/13017#discussion_r2011876814
##########
hudi-common/src/main/java/org/apache/hudi/common/util/hash/BucketIndexUtil.java:
##########
@@ -35,8 +35,8 @@ public class BucketIndexUtil {
* @param parallelism Parallelism of the task
* @return The partition index of this bucket.
*/
- public static Functions.Function2<String, Integer, Integer>
getPartitionIndexFunc(int bucketNum, int parallelism) {
- return (partition, curBucket) -> {
+ public static Functions.Function3<Integer, String, Integer, Integer>
getPartitionIndexFunc(int parallelism) {
+ return (bucketNum, partition, curBucket) -> {
Review Comment:
Not sure this is correct, seems not if the bucketNum does not equal among
partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]